Not sure why Goldman hasn't replaced her. I can replace her in a 5 lines of java: public class AbbyCohen implements SomePredictionInterface { public boolean isMarketABuy([infinite numbers of parameters]) { return true; } }
What's important for GS is that Ms. Cohen *ALWAYS* has an opinion (i.e. she should never "not have a view on the market"). This fulfills her role at GS - which is specifically to give people another reason to trade. Note, she doesn't even have to believe the market is under or over valued. It could be "fair" valued - and still give a person a reason to trade. Please note that Ms. Cohen, like everybody else, also has an asshole. That doesn't mean hers is better than yours.
There are any number of ways a Goldman Sachs employee can get rich. So if Abby Cohen is rich she certainly didn't get that way on the basis of her accuracy in calling market moves (at least not the calls she made available to the public). Cohen was right only when the market happened to be down and later went up. A sign pasted to the wall that says "Stocks are going up!" will be just as accurate as Abby Cohen and will be a lot cheaper to employ.