Which is better long box spread or short box spread? SPX ?

Short box spread has early assignment risk - I understand but for example if am trading SPX - which is better long vs short box spread ?

 

Be careful with box spreads. Look for some videos from tasty trade about it on YouTube. They explain the traps hidden in those boxes.

 

While someone is at it, can they explain, which is better: yellow or black?